Use JUnit 5 and remove JUnit 4 API dependencies#64
Conversation
|
@marcphilipp @britter can you pls check if the direction is sensible? |
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
I think we should consider offering a more gradual migration path from JUnit 4 to 5. We could deprecate the Runner implementation and the old annotations for now and use the same execution logic behind the scenes. WDYT?
| } | ||
|
|
||
| @Override | ||
| public TestDescriptor discover(EngineDiscoveryRequest discoveryRequest, UniqueId uniqueId) { |
There was a problem hiding this comment.
Discovery should also support UniqueIdSelectors and use EngineDiscoveryRequestResolver for de-duplication.
| Function<CommandExecutorParams, CommandExecutor> commandExecutorFunction, List<? extends OutputNormalizer> normalizers, | ||
| List<SampleModifier> sampleModifiers | ||
| ) { | ||
| super(uniqueId, sample.getId()); |
There was a problem hiding this comment.
We should pass a FileSource here so that one can navigate to the source in IDEs.
| } | ||
|
|
||
| @Override | ||
| public void execute(ExecutionRequest request) { |
There was a problem hiding this comment.
Extending HierarchicalTestEngine would allow to move the execution logic to the TestDescriptor.
pbielicki
force-pushed
the
przemek/junit-platform-engine
branch
from
d62586d to
a9fcbe6
Compare
makes perfect sense |
pbielicki
force-pushed
the
przemek/junit-platform-engine
branch
from
a9fcbe6 to
0f85578
Compare
2 participants
No description provided.